Skip to content

Support for ActiveSupport log subscribers #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Support for ActiveSupport log subscribers #2676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93d71ee
Update Gemfile.dev
solnic Aug 20, 2025
e779cdb
Clean up Gemfile.dev
solnic Aug 26, 2025
7e59ae7
[rails] update psych for rails 7.1+
solnic Aug 26, 2025
4417bf9
[rails] update dummy app's constant
solnic Aug 26, 2025
98226ec
[rails] add bin/test
solnic Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ node_modules

.devcontainer/.env
vendor/gems
sentry-rails/Gemfile-*.lock
33 changes: 25 additions & 8 deletions Gemfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,39 @@ ruby_version = Gem::Version.new(RUBY_VERSION)
if ruby_version >= Gem::Version.new("2.7.0")
gem "debug", github: "ruby/debug", platform: :ruby
gem "irb"
gem "ruby-lsp-rspec" if ruby_version >= Gem::Version.new("3.0.0") && RUBY_PLATFORM != "java"
end

if RUBY_VERSION >= "3.5"
if ruby_version >= Gem::Version.new("2.5")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent CGI Gem Requirement Across Ruby Versions

The cgi gem is now required for Ruby 2.5+, but it was only extracted from the standard library in Ruby 3.0. This leads to unnecessary installation and potential conflicts for Ruby 2.5-2.7, where it's already built-in.

Fix in Cursor Fix in Web

gem "cgi"
end

# For RSpec
gem "rspec", "~> 3.0"
if ruby_version >= Gem::Version.new("3.4")
gem "drb"
gem "mutex_m"
gem "benchmark"
gem "base64"
gem "ostruct"
end

# RSpec
gem "rspec"
gem "rspec-retry"

if ruby_version >= Gem::Version.new("3.0") && RUBY_PLATFORM != "java"
gem "ruby-lsp-rspec"
end

# Coverage
gem "simplecov"
gem "simplecov-cobertura", "~> 1.4"
gem "rexml"

if ruby_version >= Gem::Version.new("3.4")
gem "ostruct"
# Do not change it without checking that `CI=true COVERAGE=true bundle exec rake`
# passes in all projects
if ruby_version >= Gem::Version.new("2.5")
gem "rexml", "3.4.1"
gem "simplecov-cobertura", "~> 3.0"
else
gem "rexml", "3.2.5"
gem "simplecov-cobertura", "~> 1.4.0"
end

group :rubocop do
Expand Down
3 changes: 2 additions & 1 deletion sentry-rails/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ if rails_version >= Gem::Version.new("8.0.0")
gem "rspec-rails"
gem "sqlite3", "~> 2.1.1", platform: :ruby
elsif rails_version >= Gem::Version.new("7.1.0")
gem "psych", "~> 4.0.0"
gem "rspec-rails"
gem "sqlite3", "~> 1.7.3", platform: :ruby
elsif rails_version >= Gem::Version.new("6.1.0")
Expand All @@ -47,8 +48,8 @@ elsif rails_version >= Gem::Version.new("6.1.0")
gem "sqlite3", "~> 1.6.9", platform: :ruby
end
else
gem "rspec-rails", "~> 4.0"
gem "psych", "~> 3.0.0"
gem "rspec-rails", "~> 4.0"

if rails_version >= Gem::Version.new("6.0.0")
gem "sqlite3", "~> 1.4.0", platform: :ruby
Expand Down
Loading
Loading