fix(actix): capture only server errors #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #877 +/- ##
==========================================
+ Coverage 73.13% 73.29% +0.16%
==========================================
Files 64 64
Lines 7366 7407 +41
==========================================
+ Hits 5387 5429 +42
+ Misses 1979 1978 -1 🚀 New features to boost your workflow:
|
Swatinem
approved these changes
Aug 4, 2025
szokeasaurusrex
approved these changes
Aug 5, 2025
| let req = TestRequest::get().uri("/test").to_request(); | ||
| let res = app.call(req).await; | ||
| assert!(res.is_err()); | ||
| assert!(res.unwrap_err().error_response().status().is_client_error()); |
There was a problem hiding this comment.
[nit] I would check the exact status code, not just that it is a client error here
| let req = TestRequest::get().uri("/test").to_request(); | ||
| let res = app.call(req).await; | ||
| assert!(res.is_err()); | ||
| assert!(res.unwrap_err().error_response().status().is_server_error()); |
There was a problem hiding this comment.
[nit] also would check exact status code here
|
looks good, couple of small (mostly optional) suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, if a middleware processing the request after the Sentry one returned an error, we would capture it unconditionally.
With this change, we capture it only if it's a server error.
(note that the behavior was correct for responses returned by services (i.e. request handler, not middleware), as at line 373 we check if it's a server error).
This is one of the possible ways to tackle this, and I think this is the one that makes most sense for the following reasons:
It must be said that there is a small possibility that someone misses this in the changelog who was actually relying on these errors to show up in Sentry.
Close #876