-
-
Notifications
You must be signed in to change notification settings - Fork 68
test(react-native): Add E2E Tests verifying RN Android project builds correctly #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #993 +/- ##
=======================================
Coverage 27.98% 27.98%
=======================================
Files 130 130
Lines 14233 14233
Branches 882 882
=======================================
Hits 3983 3983
Misses 10233 10233
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwd = path.join(projectDir, 'android'); | ||
env = { SENTRY_DISABLE_AUTO_UPLOAD: 'true' }; | ||
} else { | ||
// ios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS will be handled separately since it needs to run only on MacOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed up in #995
# Conflicts: # e2e-tests/test-applications/react-native-expo-test-app/package.json # e2e-tests/tests/react-native.test.ts # e2e-tests/utils/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking it as DRAFT to discuss further before merging 🙏
Based on: #992
Part of #948
Description
Adds E2E tests verifying React Native Android project builds correctly
main
(just bundling)Given the increase in the CI checks time (currently the longest checks take ~3m to ~3.3m) and the fact that adding the iOS build checks will increase this time even further, I suggest to use this PR to discuss if we want the RN build checks to run only on specific cases or not at all.
To test locally run:
yarn test:e2e React-Native
#skip-changelog