Skip to content

Conversation

antonis
Copy link
Contributor

@antonis antonis commented May 8, 2025

Based on: #992

Part of #948

Description

Adds E2E tests verifying React Native Android project builds correctly

⚠️ Please consider that building the project increases the CI checks time significantly. Some indicative times in the table below.

React-Native E2E Tests main(just bundling) this PR
ubuntu-latest 1m 39s 7m 27s
macos-15 1m 36s 6m 3s

Given the increase in the CI checks time (currently the longest checks take ~3m to ~3.3m) and the fact that adding the iOS build checks will increase this time even further, I suggest to use this PR to discuss if we want the RN build checks to run only on specific cases or not at all.

To test locally run:

  • yarn test:e2e React-Native

#skip-changelog

Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.98%. Comparing base (8255186) to head (75903d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   27.98%   27.98%           
=======================================
  Files         130      130           
  Lines       14233    14233           
  Branches      882      882           
=======================================
  Hits         3983     3983           
  Misses      10233    10233           
  Partials       17       17           
Flag Coverage Δ
unit-tests 27.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antonis antonis changed the title test(react-native): Add E2E Tests verifying the project builds correctly test(react-native): Add E2E Tests verifying RN Android project builds correctly May 8, 2025
cwd = path.join(projectDir, 'android');
env = { SENTRY_DISABLE_AUTO_UPLOAD: 'true' };
} else {
// ios
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS will be handled separately since it needs to run only on MacOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed up in #995

@antonis antonis requested a review from krystofwoldrich May 8, 2025 15:48
@antonis antonis marked this pull request as ready for review May 8, 2025 15:48
Base automatically changed from antonis/rn-e2e-bundle to master June 20, 2025 11:53
# Conflicts:
#	e2e-tests/test-applications/react-native-expo-test-app/package.json
#	e2e-tests/tests/react-native.test.ts
#	e2e-tests/utils/index.ts
@antonis antonis marked this pull request as draft June 26, 2025 08:33
Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking it as DRAFT to discuss further before merging 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant