-
-
Notifications
You must be signed in to change notification settings - Fork 68
feat: Add option to NextJS for creating sentry rules LLM file #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add option to NextJS for creating sentry rules LLM file ([#997](https://github.com/getsentry/sentry-wizard/pull/997)) If none of the above apply, you can opt out of this check by adding |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
==========================================
- Coverage 27.98% 27.86% -0.13%
==========================================
Files 130 130
Lines 14233 14300 +67
Branches 882 882
==========================================
+ Hits 3983 3984 +1
- Misses 10233 10299 +66
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/nextjs/nextjs-wizard.ts
Outdated
clack.log.error( | ||
`Failed to create ${chalk.cyan( | ||
'sentryrules.md', | ||
)} in ${chalk.cyan('.rules')} directory. Please create it manually.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we give them a link for the content to put this into the file? Or even a curl
one-liner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I love that idea. Sort of a "Couldn't do it, you can create it manually though!". Great suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't fully look at this PR yet (on my list for tomorrow) but to get CI to pass, please update the NextJS E2E tests in the repo. Looks like they time out because we added a user prompt to the wizard which we don't answer in the CLI interaction in the e2e tests.
Let me know if you need help with updating the tests.
Also it looks like the lint job is failing. Running yarn fix
or yarn fix:prettier
should solve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Left a comment about the e2e test, some questions and ideas for rules and a minor style correction. Thanks for working on this!
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Hey @codyde are you still working on this? Just checking in since I'm going over older PRs to see if we can close some of them. No pressure, happy to keep it open. |
- Add IDE selection prompt (Cursor, VS Code, Claude Code) - Implement IDE-specific file paths and formats: - Cursor: .cursorrules with special header - VS Code: .github/instructions/sentryrules.md - Claude Code: sentryrules.md in root - Create shared ai-rules module for consistency across wizards - Add AI rules support to all framework wizards with framework-specific content - Fix test issues and add comprehensive unit tests - Clean up duplicate code and use shared functionality
Adding a step to the NextJS wizard which either uses a .rules folder or gives the option to create one, and places a sentryrules file in there that can be used with LLMs
This rules file includes basic up to date examples for tracing, logging, and error tracking / exceptions.
Based off of a discussion with @HazAT.