-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(autofix): Duplicate check for automation runs #102933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
JoshFerge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ttl should prolly be minutes, not 1 hour. the automation task has a 35 sec. limit w/ 1 retry. if something flakily fails in the automation task (e.g., gemini 429s) and we don't actually trigger autofix, we'll be delaying the next automation run for 1 hour. during that time it's possible someone would've wanted an RCA on their issue
if the ttl is minutes, then as long as a new event comes in after that, autofix has another chance to get triggered
or, if the automation task fails, delete the key. that feels a little riskier tho
Okay will change to 15 minutes |
kddubey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could prolly be 5 minutes
Hmm 5 seems a bit too close. Will take it down to 10. |
aa4a944 to
42b39c0
Compare
PR Details