ci: Fix Github job to run python3 -m tools.api_urls_to_typescript #102935
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the job wasnt running properly because `env.SECRET_ACCESS` was some copy+pasta that doesnt work in this workflow. Instead the fix is to stop the job on failure, and have fewer conditions on each step
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - # get a non-default github token so that any changes are verified by CI | ||
| if: env.SECRET_ACCESS == 'true' | ||
| uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0 | ||
| - uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0 |
Contributor
There was a problem hiding this comment.
Bug: Token Step Fails Job; Continue-On-Error Missing
The action-github-app-token step lacks continue-on-error: true, causing the entire job to fail if token generation fails. This prevents python3 -m tools.api_urls_to_typescript from running, unlike similar jobs (requirements, typing) which use continue-on-error: true to ensure the main task executes regardless of token availability.
pop2015wax
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the job wasnt running properly because
env.SECRET_ACCESSwas some copy+pasta that doesnt work in this workflow. Instead the fix is to stop the job on failure, and have fewer conditions on each step