feat(generation-page): Add column selector #102940
Open
+176
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| {key: SpanFields.TIMESTAMP, name: t('Timestamp')}, | ||
| ] as const; | ||
| const columnWidths: Partial<Record<GenerationFields, number>> = { | ||
| [SpanFields.SPAN_ID]: 100, |
Contributor
There was a problem hiding this comment.
Bug: Mismatched Span ID Enum Breaks Column Widths
The columnWidths map uses SpanFields.SPAN_ID but the table rendering and default fields use SpanFields.ID. These are different enum values ('span_id' vs 'id'), causing the column width configuration to never match and apply to the actual ID column being rendered.
|
|
||
| return ( | ||
| <div> | ||
| <Container> |
Contributor
There was a problem hiding this comment.
Bug: ForceCellGrow Fails After Field Key Change
The forceCellGrow check uses SpanFields.GEN_AI_REQUEST_MESSAGES, but after the changes this field is no longer a valid column key since it's been replaced by INPUT_OUTPUT_FIELD in the column configuration. This will cause the force cell grow logic to never trigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-11-06.at.17.33.05.mov