Skip to content

feat(ui): Add hasExternalChanges prop to HybridFilter #102957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

feat(ui): Add hasExternalChanges prop to HybridFilter #102957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions static/app/components/organizations/hybridFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ export interface HybridFilterProps<Value extends SelectKey>
* Useful for things like enforcing a selection count limit.
*/
disableCommit?: boolean;
/**
* Additional staged changes from external state that should trigger
* the Apply/Cancel buttons.
*/
hasExternalChanges?: boolean;
/**
* Message to show in the menu footer
*/
Expand Down Expand Up @@ -96,6 +101,7 @@ export function HybridFilter<Value extends SelectKey>({
checkboxWrapper,
checkboxPosition,
disableCommit,
hasExternalChanges = false,
...selectProps
}: HybridFilterProps<Value>) {
/**
Expand All @@ -115,11 +121,13 @@ export function HybridFilter<Value extends SelectKey>({
}, [onStagedValueChange, stagedValue]);

/**
* Whether there are staged, uncommitted changes. Used to determine whether we should
* show the "Cancel"/"Apply" buttons.
* Whether there are staged, uncommitted changes, or external changes. Used to determine
* whether we should show the "Cancel"/"Apply" buttons.
*/
const hasStagedChanges =
stagedValue.length !== value.length || !stagedValue.every(val => value.includes(val));
stagedValue.length !== value.length ||
!stagedValue.every(val => value.includes(val)) ||
hasExternalChanges;

const commit = useCallback(
(val: Value[]) => {
Expand Down
Loading