ref: use msw for network mocking in tests #102962

TkDodo · 2025-11-07T16:37:41Z

No description provided.

codecov · 2025-11-07T16:45:41Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
12393	2	12391	10

View the top 2 failed test(s) by shortest run time

PrimaryNavigationServiceIncidents displays button and list of incidents when clicked

Stack Traces | 1.01s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

[MSW] Error: intercepted a request without a matching request handler:

  • GET https://sentry.status.sentry..../v2/incidents/unresolved.json

If you still wish to intercept this unhandled request, please create a request handler for it.
Read more: https://mswjs..../docs/http/intercepting-requests
    at console.captureMessage [as error] (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.error (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../utils/internal/devUtils.ts:24:11)
    at applyStrategy (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../utils/request/onUnhandledRequest.ts:39:18)
    at error (.../tests/js/setupMsw.ts:17:13)
    at onUnhandledRequest (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../utils/request/onUnhandledRequest.ts:68:5)
    at handleRequest (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../core/utils/handleRequest.ts:79:11)
    at _Emitter.<anonymous> (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../src/node/SetupServerCommonApi.ts:60:26)
    at emitAsync (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../src/utils/emitAsync.ts:23:5)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../src/utils/handleRequest.ts:123:5
    at until (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../until/src/until.ts:23:18)
    at handleRequest (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../src/utils/handleRequest.ts:112:18)
    at globalThis.fetch (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../interceptors/fetch/index.ts:185:7)
    at queryFn (.../app/utils/useServiceIncidents.tsx:46:16)
    at flushUnexpectedConsoleCalls (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:145:7)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusHook (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:978:40)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:951:5)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:494:12)

PrimaryNavigationServiceIncidents should not show anything if there are no incidents

Stack Traces | 1.02s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

[MSW] Error: intercepted a request without a matching request handler:

  • GET https://sentry.status.sentry..../v2/incidents/unresolved.json

If you still wish to intercept this unhandled request, please create a request handler for it.
Read more: https://mswjs..../docs/http/intercepting-requests
    at console.captureMessage [as error] (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.error (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../utils/internal/devUtils.ts:24:11)
    at applyStrategy (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../utils/request/onUnhandledRequest.ts:39:18)
    at error (.../tests/js/setupMsw.ts:17:13)
    at onUnhandledRequest (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../utils/request/onUnhandledRequest.ts:68:5)
    at handleRequest (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../core/utils/handleRequest.ts:79:11)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _Emitter.<anonymous> (.../sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]..../src/node/SetupServerCommonApi.ts:60:26)
    at emitAsync (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../src/utils/emitAsync.ts:23:5)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../src/utils/handleRequest.ts:123:5
    at until (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../until/src/until.ts:23:18)
    at handleRequest (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../src/utils/handleRequest.ts:112:18)
    at globalThis.fetch (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../interceptors/fetch/index.ts:185:7)
    at queryFn (.../app/utils/useServiceIncidents.tsx:46:16)
    at flushUnexpectedConsoleCalls (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/node_modules/.pnpm/[email protected]..../node_modules/jest-fail-on-console/index.js:145:7)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusHook (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:978:40)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:951:5)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

because it somehow doesn't work with the mockApi adapter anymore ¯\_(ツ)_/¯

because we now hav passthrough() events that also get logged with request:start

TkDodo added 5 commits November 7, 2025 16:12

this works I don't want to lose it

8cfe5f6

use cross-fetch polyfill

2edcb71

re-enable fetchMocks (doesn't hurt)

22da920

fix: allow un-mocking the global API client

1d87d02

rewrite remaining tests to msw

bd73526

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 7, 2025

vercel bot deployed to Preview November 7, 2025 16:39 View deployment

fix: initApiClientErrorHandling and hasProjectBeenRenamed

d91c397

vercel bot deployed to Preview November 7, 2025 20:57 View deployment

TkDodo added 4 commits November 8, 2025 11:32

merge branch master

477ef7f

fix: mock requests to release-registry.services.sentry.io

a5f85ab

ref: remove unnecessary fallback

269aeb9

fix: rewrite groupingStore.spec to USE_REAL_API

90f1355

because it somehow doesn't work with the mockApi adapter anymore ¯\_(ツ)_/¯

vercel bot deployed to Preview November 8, 2025 11:57 View deployment

fix: passthrough for requests going to sentry ingest

62d2e65

vercel bot deployed to Preview November 8, 2025 12:29 View deployment

oops this should be beforeEach

41df7b7

vercel bot deployed to Preview November 8, 2025 12:40 View deployment

ok try the warn strategy

e4511dd

vercel bot deployed to Preview November 8, 2025 12:48 View deployment

fix: maybe like this?

7604cf3

vercel bot deployed to Preview November 8, 2025 13:29 View deployment

fix: listen to response:mocked

5771b52

because we now hav passthrough() events that also get logged with request:start

vercel bot deployed to Preview November 8, 2025 15:26 View deployment

test: fake timers

2c7a68b

vercel bot deployed to Preview November 8, 2025 18:31 View deployment

test: fake timers (another one)

46f5b6e

vercel bot deployed to Preview November 8, 2025 18:47 View deployment

test: just to see if that is responsible for the timing differences

d4a6823

Merge branch 'master' into tkdodo/ref/msw-poc

42a5248

vercel bot deployed to Preview November 8, 2025 20:45 View deployment

TkDodo added 2 commits November 10, 2025 11:04

Merge branch 'master' into tkdodo/ref/msw-poc

7569da0

test: bisect timing increase in CI

647e4b2

vercel bot deployed to Preview November 10, 2025 10:08 View deployment

bring back passthrough

a728281

vercel bot deployed to Preview November 10, 2025 10:41 View deployment

revert jest config

433e2b2

vercel bot deployed to Preview November 10, 2025 12:14 View deployment

okay let's try with bypass

be611f7

vercel bot deployed to Preview November 10, 2025 12:43 View deployment

test custom handler

99f29fe

vercel bot deployed to Preview November 10, 2025 13:00 View deployment

TkDodo added 2 commits November 10, 2025 14:08

go back to the real thing

878a150

Merge branch 'master' into tkdodo/ref/msw-poc

b6986a8

vercel bot deployed to Preview November 10, 2025 13:11 View deployment

ref: switch the only jest-fetch-mock test to msw

ffe0137

vercel bot deployed to Preview November 10, 2025 13:22 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ref: use msw for network mocking in tests #102962

ref: use msw for network mocking in tests #102962

TkDodo commented Nov 7, 2025

Uh oh!

codecov bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

ref: use msw for network mocking in tests #102962

Are you sure you want to change the base?

ref: use msw for network mocking in tests #102962

Conversation

TkDodo commented Nov 7, 2025

Uh oh!

codecov bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Nov 7, 2025 •

edited

Loading