-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(replay): prevent dup initial summary requests and ref to use usetimeout #99182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets take a look at this file together.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99182 +/- ##
===========================================
+ Coverage 66.63% 81.23% +14.60%
===========================================
Files 8575 8551 -24
Lines 379872 377273 -2599
Branches 24125 23991 -134
===========================================
+ Hits 253120 306491 +53371
+ Misses 126390 70427 -55963
+ Partials 362 355 -7 |
ryan953
approved these changes
Sep 15, 2025
aliu39
commented
Sep 15, 2025
|
||
// Auto-start logic. | ||
// TODO: remove the condition segmentCount <= 100 | ||
// when BE is able to process more than 100 segments. Without this, generation will loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need 100 segment condition anymore because the ref guarantees we only auto-POST once per page load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there's a chance we'll send additional start summary POST requests after the first finishes. Only one of these should be made per page load (segment count won't update until hard reload).
closes REPLAY-670: frontend should prevent infinite polling
Updates to polling timeout to useTimeout and simplifies shouldPoll (removing dependency on startSummaryRequestPending)