Skip to content

fix(dashboards): consolidate btn area #99543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

fix(dashboards): consolidate btn area #99543

merged 2 commits into from
Sep 16, 2025

Conversation

doralchan
Copy link
Contributor

@doralchan doralchan commented Sep 15, 2025 •
edited
Loading

  • Removed give feedback button in favor of the All Dashboards give feedback button
  • Simplified edit dashboard button with text to icon
  • Changed "Edit Access" to "Editors"
  • Clarified what the editor dropdown is for in the tooltip
  • Changed the concept of "Favoriting" to "Starring" to align with navbar
  • Added tooltips for all the icon btns
  • Changed "All Users" to "Select All" in the dropdown

Before:
Screenshot 2025-09-15 at 2 52 24 PM

Screenshot 2025-09-15 at 2 54 00 PM

After:
Screenshot 2025-09-15 at 2 52 31 PM

Screenshot 2025-09-15 at 2 53 53 PM

@doralchan doralchan requested a review from a team as a code owner September 15, 2025 21:40
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 15, 2025
@getsentry getsentry deleted a comment from cursor bot Sep 15, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 15, 2025 •
edited
Loading

✅ All tests passed

@doralchan doralchan requested review from bcoe and removed request for bcoe September 15, 2025 21:56
@doralchan doralchan force-pushed the fix/dashboards-btn-wall branch from d8e9596 to 260f002 Compare September 15, 2025 22:15
@doralchan doralchan marked this pull request as draft September 15, 2025 22:46
@doralchan doralchan force-pushed the fix/dashboards-btn-wall branch from 10276f6 to c92e8d5 Compare September 15, 2025 23:41
@doralchan doralchan force-pushed the fix/dashboards-btn-wall branch from 5ecd986 to 16901fe Compare September 16, 2025 16:02
@doralchan doralchan marked this pull request as ready for review September 16, 2025 16:14
@doralchan doralchan requested a review from gggritso September 16, 2025 16:15
gggritso
gggritso reviewed Sep 16, 2025
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Cursor for once, but otherwise LGTM!

@getsentry getsentry deleted a comment from cursor bot Sep 16, 2025
@doralchan
Copy link
Contributor Author

doralchan commented Sep 16, 2025 •
edited
Loading

@gggritso making the updates

cursor[bot]

This comment was marked as outdated.

Sign in to view

@doralchan doralchan force-pushed the fix/dashboards-btn-wall branch from 671bb30 to 3cee209 Compare September 16, 2025 16:32
bcoe
bcoe approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a product perspective 👍

@doralchan doralchan merged commit fb9790d into master Sep 16, 2025
46 checks passed
@doralchan doralchan deleted the fix/dashboards-btn-wall branch September 16, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggritso gggritso gggritso left review comments

@cursor cursor[bot] cursor[bot] left review comments

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doralchan @bcoe @gggritso