fix(checkout v3): UI tweaks #99554
Merged
fix(checkout v3): UI tweaks #99554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit daae74a Author: isabellaenriquez <[email protected]> Date: Fri Sep 12 09:20:37 2025 -0400 add breakpoint commit 5838176 Author: isabellaenriquez <[email protected]> Date: Thu Sep 11 17:52:17 2025 -0400 move price warning commit 29187c0 Author: isabellaenriquez <[email protected]> Date: Thu Sep 11 17:28:13 2025 -0400 feat(checkout v3): New plan feature list
github-actions
bot
added
the
Scope: Frontend
|
✅ All tests passed |
Comment on lines
909
to
917
| <Grid | ||
| <Flex | ||
| direction="column" | ||
| align="start" | ||
| gap="2xl" | ||
| columns={{ | ||
| sm: 'auto', | ||
| md: isNewCheckout ? '3fr 2fr' : 'auto', | ||
| lg: '3fr 2fr', | ||
| }} | ||
| maxWidth={isNewCheckout ? '1440px' : undefined} | ||
| padding={isNewCheckout ? '2xl' : undefined} |
There was a problem hiding this comment.
this regresses existing checkout
There was a problem hiding this comment.
i also noticed if you collapse all the sections the layout gets weird
There was a problem hiding this comment.
ah crap thought i fixed that, good catch
| `Annual subscriptions require a one-year non-cancellable commitment. | ||
| By using Sentry you agree to our [terms: Terms of Service].`, | ||
| {terms: <a href="https://sentry.io/terms/" />} | ||
| <LogoSentry height="24px" /> |
There was a problem hiding this comment.
this shouldn't show up in existing checkout
Comment on lines
172
to
179
| <Grid columns="1fr 1fr" gap="xl"> | ||
| <ProductSelect | ||
| activePlan={activePlan} | ||
| formData={formData} | ||
| onUpdate={onUpdate} | ||
| isNewCheckout | ||
| /> | ||
| </Grid> |
There was a problem hiding this comment.
i think we'll need to move this grid into ProductSelect itself but we can cross this bridge when we have other products later :)
There was a problem hiding this comment.
also should we add breakpoints?
There was a problem hiding this comment.
yeah i figured this was a bandaid for now, i'll add the breakpoint too!
- add translation to cart label - change structure to show new layout on isNewCheckout - responsive grid
isabellaenriquez
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making some broad stroke changes to the new checkout UI