documentation: add layering and elevation principle #99560
+106
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -333,7 +343,7 @@ export function useStoryTree( | |||
| } | |||
|
|
|||
| if (i === parts.length - 1) { | |||
| parent.children[name] = new StoryTreeNode(name, type, file); | |||
| parent.children[name] = new StoryTreeNode(formatName(name), type, file); | |||
There was a problem hiding this comment.
Bug: Node Naming Inconsistency Affects Tree Structure
Applying formatName to StoryTreeNode names at creation changes their internal representation. This creates inconsistency with how nodes are keyed in the tree, breaks special handling for "use" hook files, and universally alters the display of all story names, potentially affecting search.
There was a problem hiding this comment.
We only format the last component, which is the filename, so this is ok.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99560 +/- ##
=======================================
Coverage 81.23% 81.23%
=======================================
Files 8585 8585
Lines 380206 380205 -1
Branches 24122 24122
=======================================
Hits 308865 308865
+ Misses 70979 70978 -1
Partials 362 362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at migrating Layering and Elevation to documentation.