fix: Pagination not working on Client Keys page #99562
Open
+62
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99562 +/- ##
==========================================
- Coverage 81.24% 81.24% -0.01%
==========================================
Files 8588 8588
Lines 380057 380056 -1
Branches 24074 24074
==========================================
- Hits 308771 308770 -1
Misses 70923 70923
Partials 363 363 |
shellmayr
reviewed
Sep 16, 2025
Comment on lines
+53
to
+65
| } = useApiQuery<ProjectKey[]>( | ||
| [ | ||
| `/projects/${organization.slug}/${projectId}/keys/`, | ||
| { | ||
| query: { | ||
| cursor: decodeScalar(location.query.cursor), | ||
| }, | ||
| }, | ||
| ], | ||
| { | ||
| staleTime: 0, | ||
| } | ||
| ); |
There was a problem hiding this comment.
Should we pass in the per-page attribute here as well? I'm aware of #99563, but if that default changes at any point in time, this page will look different again.
There was a problem hiding this comment.
yep, that would be even better solution. We can change the default on backend never the less, but ideally this info should be coming from the client/frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/getsentry/issue/TET-1135/project-settigns-client-keys-pagination-does-not-work