Require token for experimental features #8163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpreid
suggested changes
Aug 28, 2025
LegNeato
reviewed
Aug 28, 2025
cwfitzgerald
force-pushed
the
cw/experimental-features
branch
from
3250508 to
c02ac2d
Compare
kpreid
approved these changes
Aug 29, 2025
cwfitzgerald
force-pushed
the
cw/experimental-features
branch
from
c02ac2d to
3ef31fc
Compare
|
I think this is a great idea! |
I second this, I think its a good way to communicate that these technically not |
ErichDonGubler
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our api a bit to force people to explicitly enable experimental features with an unsafe api before they can enable them, helping to clear up that these are not yet fully sound.