Skip to content

Hermes 2 tool calling : fixed crash when <tool_call> had a newline before it #15639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hermes 2 tool calling : fixed crash when <tool_call> had a newline before it #15639

wants to merge 1 commit into from
+1 −1

Conversation

ExtReMLapin
Copy link
Contributor

Fixes #15608

@ExtReMLapin
Copy link
Contributor Author

cc for courtesy but honestly it doesn't require his greenlight to go as it's a very simple trigger/grammar fix

@ochafik

@ExtReMLapin ExtReMLapin marked this pull request as ready for review August 28, 2025 14:21
@ExtReMLapin ExtReMLapin mentioned this pull request Aug 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misc. bug: Tool calling CRASH : Unexpected empty grammar stack after accepting piece<tool_call>
2 participants
@ExtReMLapin @ggerganov