Skip to content

vulkan: clamp matmul and FA results to the max finite value #15652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2025
Merged

vulkan: clamp matmul and FA results to the max finite value #15652

merged 2 commits into from
Aug 31, 2025
+58 −8

Conversation

jeffbolznv
Copy link
Collaborator

See discussion in #15619.

@jeffbolznv jeffbolznv requested a review from 0cc4m as a code owner August 29, 2025 03:44
@jeffbolznv jeffbolznv marked this pull request as draft August 29, 2025 03:44
@jeffbolznv jeffbolznv mentioned this pull request Aug 29, 2025
Closed
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Aug 29, 2025
@jeffbolznv jeffbolznv marked this pull request as ready for review August 29, 2025 14:38
0cc4m
0cc4m reviewed Aug 30, 2025
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a performance difference, but I also can't check (easily) with gpt-oss 120B.

@0cc4m 0cc4m merged commit 94e82c7 into ggml-org:master Aug 31, 2025
45 of 48 checks passed
jeffbolznv added a commit to jeffbolznv/llama.cpp that referenced this pull request Aug 31, 2025
@jeffbolznv
vulkan: add missing clamps in new mul_mat_id paths
c4ec430 
This is a missing interaction between ggml-org#15546 and ggml-org#15652
@jeffbolznv jeffbolznv mentioned this pull request Aug 31, 2025
Merged
@starbuckscoffee starbuckscoffee mentioned this pull request Sep 1, 2025
Closed
0cc4m pushed a commit that referenced this pull request Sep 1, 2025
@jeffbolznv
vulkan: add missing clamps in new mul_mat_id paths (#15702)
35a42ed 
This is a missing interaction between #15546 and #15652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m 0cc4m approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffbolznv @0cc4m