If backends fail it is possible to try using a null pointer #3313
Conversation
src/whisper.cpp
Outdated
| buft_list.emplace_back(cpu_dev, *extra_bufts); | ||
| ++extra_bufts; | ||
| // Prevent null pointer being used in following code | ||
| if(cpu_dev != nullptr) { |
There was a problem hiding this comment.
Nit: Can you add a space after the if keyword.
There was a problem hiding this comment.
Added space after if *4 to fix nit
The most easiest way to trigger the state this avoids is by commenting out the ggml_backend_load_all() in whisper-bench and build shared all_cpu_variants. OK that error would be pretty stupid but at least with this it'll tell you there are no backends. The alternative is a core-dump which tells you less than zero
I know most perople will build static for the build-box but if you want to pass something around as a release shared all_cpu_variants is a must
Also if you pass a static release around you run into the issue of it not loading the right CPU on older kit (probably same result - not tested - yet, only just though of it)
This is, hopefully, slighly cleaner than a core dump