Support static xcframework packaging in build-xcframework.sh #3322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbev
reviewed
Jul 21, 2025
|
@richwaters Thanks for the pull request! I've not linked against a static xcframework before and create this example. Is this similar to how you are linking with the static whisper.cpp xcframework? |
Thanks for the response. I'm linking to the static xcframework via a binary target in Package.swift, but I ran your test example, and it works for me. |
danbev
approved these changes
Jul 23, 2025
BUILD_STATIC_XCFRAMEWORK option. When enabled, the build-xcframework.sh script builds a self-contained static whisper.xcframework. The motivation for this change is so that command line binaries can link whisper.cpp without forcing users to install the whisper.xcframework separately.
Co-authored-by: Daniel Bevenius <[email protected]>
…ramework creation.
…atic xcframework creation. Fix whitespaces.
danbev
force-pushed
the
feature/static-xcframework
branch
2 times, most recently
from
2e09069 to
49b2c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows for the building of a static xcframework by adding a BUILD_STATIC_XCFRAMEWORK option. When enabled, the build-xcframework.sh script builds a static whisper.xcframework.
The motivation for this change is so that command line tools can link whisper.cpp without forcing users to install the whisper.xcframework separately.