Store and get selected repos on ticket to Atlassian storage

[hiroshinishio]

No description provided.

[sourcery-ai]

Hey @hiroshinishio - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Consider adding user feedback for error cases

Silent failures can lead to confusion. Consider showing a notification or error message to the user when the save operation fails.

      console.error("Error saving repo:", error);
      toast.error("Failed to save repository. Please try again.");

[sourcery-ai]

suggestion: Include response body in error message for better debugging

Consider including the response body in the error message to provide more context for debugging: const body = await response.text(); throw new Error(Failed to fetch repositories: ${response.status} - ${body});

Suggested change

	if (!response.ok) throw new Error(`Failed to fetch repositories: ${response.status}`);
	if (!response.ok) {
	const body = await response.text();
	throw new Error(`Failed to fetch repositories: ${response.status} - ${body}`);
	}

[sourcery-ai]

issue (complexity): Consider consolidating related state management and repository logic into dedicated custom hooks

The code can be simplified by combining related effects and extracting repository logic into a custom hook. Here's how:

1. Combine context-related state management:

const useJiraContext = () => {
  const context = useProductContext();
  const [contextData, setContextData] = useState({
    cloudId: null,
    projectId: null,
    issueId: null
  });

  useEffect(() => {
    if (context) {
      setContextData({
        cloudId: context.cloudId,
        projectId: context.extension.project.id,
        issueId: context.extension.issue.id
      });
    }
  }, [context]);

  return contextData;
};

2. Extract repository management into a custom hook:

const useRepositoryManagement = (cloudId, projectId, issueId) => {
  const [githubRepos, setGithubRepos] = useState([]);
  const [isLoading, setIsLoading] = useState(true);
  const [selectedRepo, setSelectedRepo] = useState("");

  useEffect(() => {
    if (!cloudId || !projectId) return;

    const loadData = async () => {
      setIsLoading(true);
      try {
        const [repos, savedRepo] = await Promise.all([
          invoke("getGithubRepos", { cloudId, projectId }),
          invoke("getStoredRepo", { cloudId, projectId, issueId })
        ]);
        setGithubRepos(repos.map(repo => `${repo.github_owner_name}/${repo.github_repo_name}`));
        setSelectedRepo(savedRepo || "");
      } catch (error) {
        console.error("Error loading repository data:", error);
      } finally {
        setIsLoading(false);
      }
    };
    loadData();
  }, [cloudId, projectId, issueId]);

  const handleRepoChange = async (value) => {
    setSelectedRepo(value);
    if (!cloudId || !projectId) return;
    try {
      await invoke("storeRepo", { cloudId, projectId, issueId, value });
    } catch (error) {
      console.error("Error saving repo:", error);
    }
  };

  return { githubRepos, selectedRepo, isLoading, handleRepoChange };
};

This refactoring reduces complexity by:

• Combining related context effects into a single hook
• Centralizing repository management logic
• Reducing state management boilerplate
• Parallel loading of repository data