Skip to content

Unconditionally disable combining SARIF files for GHES 3.18 #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unconditionally disable combining SARIF files for GHES 3.18 #2961

wants to merge 1 commit into from

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Jul 4, 2025

This unconditionally disables combining of SARIF files with non-unique categories for GHES 3.18 since this feature is unsupported on GHES 3.18. For dotcom (and GHEC-DR), we'll depend on the feature flag for now.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@koesie10 koesie10 force-pushed the koesie10/disable-combine-sarif-files-ghes branch from 7d4dc4a to aafbeb2 Compare July 4, 2025 13:24
@koesie10 koesie10 marked this pull request as ready for review July 4, 2025 13:25
@Copilot Copilot AI review requested due to automatic review settings July 4, 2025 13:25
@koesie10 koesie10 requested a review from a team as a code owner July 4, 2025 13:25
Copilot
Copilot AI reviewed Jul 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@koesie10