Skip to content

Convert more queries to the new dataflow library #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025

Conversation

jketema
Copy link
Collaborator

@jketema jketema commented Jul 15, 2025

Commit-by-commit review is recommended.

jketema added 4 commits July 15, 2025 13:46
Observe that field flow requires global flow with the new library, so
a dataflow configuration is introduced.
The query seemed to depend on a bug in the old dataflow library
before, where `asDefiningArgument` could return the function call
instead of its argument.
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jketema jketema marked this pull request as ready for review July 15, 2025 14:27
@jketema jketema changed the title Conver more queries to the new dataflow library Convert more queries to the new dataflow library Jul 15, 2025
@jketema jketema merged commit 7b37153 into github:next Jul 15, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants