Rust: Update legacy MaD models 4

[geoffw0]

Final update of legacy MaD models to the new model format (continues from #19946 and should be independent of that).

There's a lot of guesswork involved in this last set of changes - i.e. cases where I couldn't find a real getCanonicalPath. There should be tests for most of them though so we will find out if we're way off.

[geoffw0]

I think it will be prudent to get the first two/three PRs merged before attempting to address the test failures here.

[aibaars]

The test failures look libc related. It looks like the fn free() in libc doesn't have a result for ItemNode::getCanonicalPath() .

The relevant bits of code are

• https://github.com/rust-lang/libc/blob/8e6f36c6ba5c91c150f2d79a06ffdc3d0b83a0f6/src/lib.rs#L75-L83
• https://github.com/rust-lang/libc/blob/8e6f36c6ba5c91c150f2d79a06ffdc3d0b83a0f6/src/unix/mod.rs#L682

I would expect the canonical path to be either libc::unix::free or libc::free.

This should address the underlying issue #19988

[geoffw0]

I've brought in the fix for extern blocks from main, fixed the libc models, and fixed a couple of typos in other models. There are still a few regressions, but I feel they're at a level where we can merge this and come back to them later.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[aibaars]

I think this should be futures_util.

Suggested change

	- ["futures-util::io::AsyncReadExt::read", "Argument[self]", "Argument[0].Reference", "taint", "manual"]
	- ["futures-util::io::AsyncReadExt::read", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"]
	- ["futures-util::io::AsyncReadExt::read_to_end", "Argument[self]", "Argument[0].Reference", "taint", "manual"]
	- ["futures-util::io::AsyncReadExt::read_to_end", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"]
	- ["futures-util::io::AsyncBufReadExt::read_line", "Argument[self]", "Argument[0].Reference", "taint", "manual"]
	- ["futures-util::io::AsyncBufReadExt::read_line", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"]
	- ["futures-util::io::AsyncBufReadExt::read_until", "Argument[self]", "Argument[1].Reference", "taint", "manual"]
	- ["futures-util::io::AsyncBufReadExt::read_until", "Argument[self].Reference", "Argument[1].Reference", "taint", "manual"]
	- ["futures-util::io::AsyncBufReadExt::fill_buf", "Argument[self]", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "taint", "manual"]
	- ["futures-util::io::AsyncBufReadExt::lines", "Argument[self]", "ReturnValue", "taint", "manual"]
	- ["futures_util::io::AsyncReadExt::read", "Argument[self]", "Argument[0].Reference", "taint", "manual"]
	- ["futures_util::io::AsyncReadExt::read", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"]
	- ["futures_util::io::AsyncReadExt::read_to_end", "Argument[self]", "Argument[0].Reference", "taint", "manual"]
	- ["futures_util::io::AsyncReadExt::read_to_end", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"]
	- ["futures_util::io::AsyncBufReadExt::read_line", "Argument[self]", "Argument[0].Reference", "taint", "manual"]
	- ["futures_util::io::AsyncBufReadExt::read_line", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"]
	- ["futures_util::io::AsyncBufReadExt::read_until", "Argument[self]", "Argument[1].Reference", "taint", "manual"]
	- ["futures_util::io::AsyncBufReadExt::read_until", "Argument[self].Reference", "Argument[1].Reference", "taint", "manual"]
	- ["futures_util::io::AsyncBufReadExt::fill_buf", "Argument[self]", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "taint", "manual"]
	- ["futures_util::io::AsyncBufReadExt::lines", "Argument[self]", "ReturnValue", "taint", "manual"]

[aibaars]

Actually might need to be <_ as futures_util::io::AsyncReadExt>::read etc.

[aibaars]

Currently the computed canonical path for this function is <core::pin::Pin as tokio::io::async_buf_read::AsyncBufRead>::poll_fill_buf which makes very little sense. I guess we should implement some auto-unpinning or something @hvitved , what do you think?

[aibaars]

Hmm the impl<P> AsyncBufRead for Pin<P> actually exists in futures-io so that canonical path is perhaps fine. Although rust-analyzer resolves the call to impl<R: AsyncRead> AsyncBufRead for BufReader<R> from futures-util. Not sure which one is best. I guess if the Pin version is in scope then it would make sense, if not, then rust-analyzer is probably right and we should have auto-unpinned somehow.

[aibaars]

I think all the MISSING annotations can be fixed by updating the models to match the actual canonical paths. The following queries can come in handy to investigate what the computed canonical paths are:

query predicate resolvedPaths2(CallExprBase e, string path, Addressable target) {
  toBeTested(e) and
  target = e.getStaticTarget() and
  path = concat(target.getCanonicalPath())
}

query predicate resolvedPaths3( Addressable target, string path) { path = target.getCanonicalPath() }