C++: Output CopyValue in the IR when there is a non-transparent conversion
#19976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
Jul 4, 2025
| (void)(q++); // $ numberOfNodes="... ++: 2" asExpr="... ++" MISSING: asExpr=q | ||
| (void)p++; // $ asExpr="... ++" asIndirectExpr="... ++" asExpr=p asIndirectExpr=p | ||
| (void)q++; // $ asExpr="... ++" asExpr=q | ||
| (p++); // $ numberOfNodes="... ++: 2" numberOfIndirectNodes="... ++: 2" asExpr="... ++" asIndirectExpr="... ++" |
There was a problem hiding this comment.
I'm a bit confused by this one. As far as I tell you've deleted the MISSING annotations and since CI still pass I guess they're still missing, no?
There was a problem hiding this comment.
I should also say: The other changes makes sense to me!
There was a problem hiding this comment.
I should have looked at the results better. I thought it would just work, because the IR looks identical to that of the two lines above it. If I also generate the CopyValue in this case, then things work.
There was a problem hiding this comment.
Fix 463ae4b Re-running DCA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures post-increment/decrement dataflow operand nodes will also be expression nodes.
commit-by-commit review is recommended.
DCA is uneventful.