Rust: Disambiguate associated function calls #19995
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1284,7 +1285,7 @@ | |||
| // siblings). | |||
| not exists(impl.getAttributeMacroExpansion()) and | |||
| // We use this for resolving methods, so exclude traits that do not have methods. | |||
| exists(Function f | f = trait.getASuccessor(_) and f.getParamList().hasSelfParam()) and | |||
| exists(Function f | f = trait.getASuccessor(_)) and | |||
Check warning
Code scanning / CodeQL
Expression can be replaced with a cast Warning
| @@ -1475,6 +1528,14 @@ | |||
| result = getTraitMethod(mc.getTypeAt(TypePath::nil()), mc.getMethodName()) | |||
| } | |||
|
|
|||
| /** Gets a method that the method call `mc` resolves to, if any. */ | |||
| cached | |||
| Function resolveCallTarget(CallExpr ce) { | |||
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
rust/disambiguate-assoc-function-calls
branch
from
fc8ff54 to
0aaedf5
Compare
hvitved
force-pushed
the
rust/disambiguate-assoc-function-calls
branch
from
0aaedf5 to
9ce2d5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.