Java: accept new test results after extractor update #20247
+77
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrissRio
force-pushed
the
idrissrio/java-upgrade-fix
branch
2 times, most recently
from
49a6500 to
ba93ced
Compare
IdrissRio
added
the
depends on internal PR
There was a problem hiding this comment.
Pull Request Overview
This PR accepts new test results after an extractor update for Java/Kotlin testing. The changes reflect updates in how the extractor processes certain type information and method declarations.
Key changes:
- Addition of
getCharsmethod detection in String class reflection tests - Removal of various collection type entries and replacement with simplified Object type mappings
- Type parameter changes from specific generic types to Object in Map declarations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java/ql/test-kotlin2/library-tests/reflection/reflection.expected | Adds getChars method entry for String class forwarder detection |
| java/ql/test-kotlin2/library-tests/java-kotlin-collection-type-generic-methods/test.expected | Removes duplicate collection entries and updates Map type parameters from Entry<?> to Object |
| java/ql/test-kotlin1/library-tests/reflection/reflection.expected | Adds getChars method entry for String class forwarder detection |
| java/ql/test-kotlin1/library-tests/java-kotlin-collection-type-generic-methods/test.expected | Removes duplicate collection entries and updates Map type parameters from Entry<?> to Object |
IdrissRio
force-pushed
the
idrissrio/java-upgrade-fix
branch
from
ba93ced to
564364b
Compare
IdrissRio
force-pushed
the
idrissrio/java-upgrade-fix
branch
from
564364b to
a34b362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See internal PR for more details.