JS: Add overlay annotations #20424
Draft
JS: Add overlay annotations #20424
+747
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
force-pushed
the
js/overlay-manual-v4
branch
2 times, most recently
from
0f6a98c to
831b225
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
asgerf
force-pushed
the
js/overlay-manual-v4
branch
6 times, most recently
from
a3235f5 to
5d28d57
Compare
asgerf
force-pushed
the
js/overlay-manual-v4
branch
2 times, most recently
from
83198f3 to
3070570
Compare
Locally these seem to get rid of the compilation warnings, but of course CI is the true arbiter here.
In this case we actually want magic to apply, but was prevented by locality.
Use manual recursion instead.
asgerf
force-pushed
the
js/overlay-manual-v4
branch
from
3070570 to
84e7101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds overlay annotations to make the
AST,CFG,SSA, andDataFlow::Nodelayers local, along with a lot of other predicates spread across the codebase that also needed to become local.