-
Notifications
You must be signed in to change notification settings - Fork 64.8k
Add missing validations showcase to checkboxes examples #41338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add missing validations showcase to checkboxes examples #41338
Conversation
ccdad8f to
90ad27c
Compare
|
Although, it seems like it has no effect 🤔 For example, I have this configuration: but I was able to create an issue without checking any of them: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds missing validations examples to checkbox form elements in the GitHub form schema documentation to maintain consistency with other input types and prevent misinterpretation of the YAML structure.
Key Changes:
- Added
validationssection to two checkbox examples in the documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| validations: | ||
| required: true |
Copilot
AI
Nov 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkbox already has required: true at the item level (line 52). Adding a top-level validations.required may be redundant or confusing. Clarify whether both are needed or if one should be removed to avoid duplication.
| validations: | |
| required: true |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
@revolter I apologize for the very late reply. Between a cold and the American holiday last week, I am trying very hard to catch up with everything. I'm not at all an expert on this, so can you explain to me what you're trying to do and what result you're getting? If needed, I can take it to the appropriate team, but only if I can articulate the question. 😅 |
Why:
To prevent incorrect interpretations of the descriptions of the YAML structure required for checkboxes (like in #41190).
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
All the other types both explain the
validationskey and then showcase it, but thecheckboxesone does not showcase it.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
datadirectory.For content changes, I have completed the self-review checklist.