fix/sentry crash modal #926
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…client.ts Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds automatic error reporting dialog functionality to the Sentry client initialization. The change implements a beforeSend hook that displays Sentry's report dialog whenever an exception occurs, allowing users to provide additional context about errors.
- Adds a
beforeSendhook to show Sentry report dialog on exceptions - Includes error handling to prevent the error reporting mechanism from causing additional errors
libraries/react-shared-libraries/src/sentry/initialize.sentry.client.ts
Outdated
Show resolved
Hide resolved
| } catch (err) { | ||
| // Prevent error reporting from causing its own errors | ||
| // Optionally log the error for debugging | ||
| // console.error('Failed to show Sentry report dialog:', err); |
There was a problem hiding this comment.
According to the project's Sentry logging guidelines, error logging should use Sentry's structured logger instead of console.error. Consider using logger.error() from Sentry with appropriate context if this line is uncommented.
Copilot generated this review using guidance from copilot-instructions.md.
…client.ts Co-authored-by: Copilot <[email protected]>
What kind of change does this PR introduce?
eg: Bug fix, feature, docs update, ...
Why was this change needed?
Please link to related issues when possible, and explain WHY you changed things, not WHAT you changed.
Other information:
eg: Did you discuss this change with anybody before working on it (not required, but can be a good idea for bigger changes). Any plans for the future, etc?
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;