Skip to content

Add 'swipeEnabled' prop #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dioseltorre wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add 'swipeEnabled' prop #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eebb59d
Add 'swipeEnabled' prop
Oct 21, 2019
6ff5d00
Add 'swipeEnabled' prop
Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ declare module 'react-native-swipe-gestures' {

export interface GestureRecognizerProps extends ViewProps {
config?: GestureRecognizerConfig;
swipeEnabled?: boolean;
onSwipe?(gestureName: string, gestureState: PanResponderGestureState): void;
onSwipeUp?(gestureState: PanResponderGestureState): void;
onSwipeDown?(gestureState: PanResponderGestureState): void;
Expand Down
9 changes: 7 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,16 @@ class GestureRecognizer extends Component {
onPanResponderTerminate: responderEnd
});
}

componentDidUpdate(prevProps) {
if (this.props.config !== prevProps.config) {
this.swipeConfig = Object.assign(swipeConfig, this.props.config);
}
}

_handleShouldSetPanResponder(evt, gestureState) {
return (
this.props.swipeEnabled &&
Copy link

@boldwade boldwade May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than setting a defaultProp value below, you could simply check if swipeEnabled is not false:
this.props.swipeEnabled !== false

evt.nativeEvent.touches.length === 1 &&
!this._gestureIsClick(gestureState)
);
Expand Down Expand Up @@ -122,4 +123,8 @@ class GestureRecognizer extends Component {
}
}

GestureRecognizer.defaultProps = {
Copy link

@boldwade boldwade May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then you can get rid of this....

swipeEnabled: true,
};

export default GestureRecognizer;