Skip to content

C#: Adds version 8 and expands nullability to reference types (#1632) #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −4
Open

C#: Adds version 8 and expands nullability to reference types (#1632) #2694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
945899c
C#: Adds version 8 and expands nullability to reference types (#1632)
Mar 26, 2025
7fb4358
C#: Adds JsonRequired attribute to System.Text.Json classes for requi…
Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/quicktype-core/src/language/CSharp/CSharpRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export class CSharpRenderer extends ConvenienceRenderer {
protected nullableCSType(t: Type, follow: (t: Type) => Type = followTargetType, withIssues = false): Sourcelike {
t = followTargetType(t);
const csType = this.csType(t, follow, withIssues);
if (isValueType(t)) {
if (isValueType(t) || this._csOptions.version >= 8) {
return [csType, "?"];
} else {
return csType;
Expand Down
5 changes: 4 additions & 1 deletion packages/quicktype-core/src/language/CSharp/SystemTextJsonCSharpRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,13 @@ export class SystemTextJsonCSharpRenderer extends CSharpRenderer {
const isNullable = followTargetType(property.type).isNullable;
const isOptional = property.isOptional;

if (isOptional && !isNullable) {
if (!isOptional) {
attributes.push(["[", "JsonRequired", "]"]);
} else if (isOptional && !isNullable) {
attributes.push(["[", "JsonIgnore", "(Condition = JsonIgnoreCondition.WhenWritingNull)]"]);
}


// const requiredClass = this._options.dense ? "R" : "Required";
// const nullValueHandlingClass = this._options.dense ? "N" : "NullValueHandling";
// const nullValueHandling = isOptional && !isNullable ? [", NullValueHandling = ", nullValueHandlingClass, ".Ignore"] : [];
Expand Down
5 changes: 3 additions & 2 deletions packages/quicktype-core/src/language/CSharp/language.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export enum Framework {
SystemTextJson = "SystemTextJson"
}

export type Version = 5 | 6;
export type Version = 5 | 6 | 8;
export interface OutputFeatures {
attributes: boolean;
helpers: boolean;
Expand Down Expand Up @@ -55,7 +55,8 @@ export const cSharpOptions = {
"C# version",
[
["5", 5],
["6", 6]
["6", 6],
["8", 8]
],
"6",
"secondary"
Expand Down