WIP: Fix shellcheck issues

api/examples/autogen.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 aclocal
 autoconf

autogen.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 echo
 echo ... GlusterFS autogen ...

build-aux/config.guess.dist

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 #
 # This script is intentionally left empty. Distributions that package GlusterFS
 # may want to to replace it with an updated copy from the automake project.

build-aux/config.sub.dist

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 #
 # This script is intentionally left empty. Distributions that package GlusterFS
 # may want to to replace it with an updated copy from the automake project.

build-aux/pkg-version

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # To override version/release from git,
 # create VERSION file containing text with version/release

extras/LinuxRPM/make_glusterrpms

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 (
     cd $(realpath $(dirname $0))/../.. || exit 1

extras/Solaris/checkinstall

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 #
 expected_platform="i386"
 #

extras/backend-cleanup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # This script can be used to cleanup the 'cluster/distribute' translator's 
 # stale link files. One may choose to run this only when number of subvolumes

extras/backend-xattr-sanitize.sh

@@ -1,7 +1,6 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 # Each entry in the array below is a regular expression to match stale keys
-
 xs=("trusted.glusterfs.createtime"
     "trusted.glusterfs.version"
     "trusted.glusterfs.afr.data-pending"
@@ -10,10 +9,12 @@ xs=("trusted.glusterfs.createtime"
 
 absolute_path()
 {
-    local dir=$(dirname "$1");
-    local base=$(basename "$1");
+    local dir
+    local base
+    dir=$(dirname "$1");
+    base=$(basename "$1");
     cd "$dir";
-    echo $(pwd)/"$base";
+    echo "$(pwd)/$base";
     cd - >/dev/null;
 }
 
@@ -23,9 +24,9 @@ cleanup()
     sanitizee=$(absolute_path "$1");
 
     stale_keys=$(
-        for pattern in ${xs[@]}; do
+        for pattern in "${xs[@]}"; do
             getfattr -d -m "$pattern" "$sanitizee" 2>/dev/null |
-            grep = | cut -f1 -d=;
+            grep -e '=' | cut -f1 -d '=';
         done
         )
 
@@ -45,7 +46,7 @@ crawl()
     this_script=$(absolute_path "$0");
 
     export sanitize=yes;
-    find "$1" -exec "$this_script" {} \;
+    find "$1" \( -exec "$this_script" {} \; \)
 }
 
 

extras/benchmarking/launch-script.sh

@@ -1,18 +1,18 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 # This script is to launch the script in parallel across all the nodes.
 
 mount_point="/mnt/glusterfs"
-path_to_script="$mount_point}/benchmark/local-script.sh"
+path_to_script="${mount_point}/benchmark/local-script.sh"
 
 num_hosts=8
 
 for i in $(seq 1 $num_hosts); do 
-    ssh node$i path_to_script &
+    ssh "node${i}" \""${path_to_script}"\" &
 done
 
 sleep 3;
 
-touch ${mount_point}/benchmark/start-test
+touch "${mount_point}"/benchmark/start-test
 
 

extras/benchmarking/local-script.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 # This script needs to be present on glusterfs mount, (ie, on every node which wants to run benchmark)
 
@@ -10,15 +10,15 @@ count=8
 
 mkdir -p testdir;
 mkdir -p output;
-echo > ${result}
+echo > "${result}"
 while [ ! -e start-test ]; do
     sleep 1;
 done;
 
 
-for i in $(seq 1 5); do 
+for (( i = 1 ; i <= 5 ; i = i + 1 )); do 
     # write
-    dd if=${ifilename} of=${ofilename} bs=${blocksize} count=${count} 2>&1 | tail -n 1 | cut -f 8,9 -d ' ' >> ${result} ;
+    dd if="${ifilename}" of="${ofilename}" bs="${blocksize}" count="${count}" 2>&1 | tail -n 1 | cut -f 8,9 -d ' ' >> "${result}" ;
     # read
     #dd if=${ofilename} of=/dev/null bs=${blocksize} count=${count} 2>&1 | tail -n 1 | cut -f 8,9 -d ' ' >> ${result} ;
 done