Add method that tells the app/backend that we are using a dark mode theme #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of it being hard coded
|
A discussed via voice, I think we need two properties:
The latter porperty is for future work, non need to implement it now. isDarkMode in this context is a little bit ambiguous. |
run. In the future, like Aqua, we might support Themes having both Light and Dark Appearance. Change wording from Mode to Appearance, since Apple has NSAppearance.
|
made an API improvement based on what I think matches closer what we need and adapted naming to what I discovered in Cocoa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add a method to make the system aware that a theme using "dark mode" is being used. This will assist in settings for editors and, particularly, with printing.