Switch to pnpm

[techknowlogick]

opening this for discussion.

I use git worktrees to work on various PRs for Gitea, leading me to have sometimes up to 20different copies of node_modules installed. This takes a toll on the available space on my hard drive. pnpm uses hardlinks&symlinks to alleviate this issue.

I understand this takes us a step away from core nodejs tools, but I think for anyone who works on several branches at a time it would benefit them.

I also had to fork the license checker to support analyzing pnpm projects.

[6543]

pnpm is awesome - but addoption is not to hight so support in other tools is till kinda lacking

[6543]

-> plz ask more devs for lgtm ... as they also have to work with it :)

[6543]

@techknowlogick would be nice if you could create a pull upstream

microsoft/license-checker-webpack-plugin@main...tklk-forks:license-checker-webpack-plugin:pnpm-support

[TheFox0x7]

My drive welcomes this as well :)

[techknowlogick]

-> plz ask more devs for lgtm ... as they also have to work with it :)

@6543 yup, that's why I also requested a review from @silverwind as they have a lot of interaction with the js side of things so I don't want to negatively impact them just for a slight improvement for me.

I requested a review from you as I know you use it with woodpecker already.

[delvh]

I'm neither for nor against it.
I lack the experience with it to judge if pnpm is a good choice or not.

Nevertheless, there seems be a clear opinion from the TOC in favor of it.
Still, it's probably best to wait for approval from the people that are most impacted by it (@silverwind and @wxiaoguang).

[wxiaoguang]

Haven't tested it. I am neutral for it.

[lunny]

Please wait for @silverwind 's review.

[denyskon]

pnpm is awesome not only because of the linking, but also because of the easily diff-able package lock file.

[silverwind]

This adds a new build dependency, so the build docs need to be updated to mention this requirement:

https://github.com/go-gitea/gitea#building

As for the change, I'm -0 because I see no need to change this package manager. gitea's node_modules consumes 629MB currently. Hard linking npm dependencies creates problems when you want to edit a dependency for debugging and has problems across file system boundaries like docker volumes. I see no benefit.

[silverwind]

I also had to fork the license checker to support analyzing pnpm projects.

I'd rather we drop the license.txt generation completely, it's been causing too much issues.