Misc icon tweaks

[silverwind]

1. Use octicon-repo-locked to indicate private repos, also visible on the repo header now
2. Use octicon-repo-forked to indicate forked repos
3. Fix pull icons on pulse page
4. Remove "gold" color from private icons, we have been removing this color on frontpage repolist, so now the rest of the UI is also consistent. Also remove the now-unused gold color.

[lunny]

But there is already a label indicating the repository is private.

[silverwind]

I guess we could remove the label with this change, possibly adding a title attribute on the icon.

[silverwind]

Both the .IsPrivate and .IsTemplate template conditions render labels and I guess for clarity we should keep these labels. I think it's not a big issue if the repo icon now additionally displays these states.

[silverwind]

Leaving for others to decide whether this is fine (both icon and tag indicate private status):

[silverwind]

Regarding octicon-repo-locked: I'm not sure it's actually right. I checked GH and they do not use it for the purpose of private repos at all. All they do is show a octicon-lock besides repo names in some places. So I think I will revert this change.

[silverwind]

Regarding octicon-repo-locked: I'm not sure it's actually right. I checked GH and they do not use it for the purpose of private repos at all. All they do is show a octicon-lock besides repo names in some places. So I think I will revert this change.

Maybe this icon is actually fine. I think a repo book icon with a padlock is better than a padlock only. We do not have a "locked" state yet for repos, so this icon is unambiguous too.

[silverwind]

One more minor change, ShowRepoAvatar is now enabled in repo lists, meaning they will render the repo avatar. This affects at least the explore repo list and org repo list.

[lunny]

A repository can fall into several state groups:

• Group 1: IsMirror, IsFork, IsRegular
• Group 2: IsTemplate
• Group 3: Public, Private

We can add icons for the states in Group 1, and use text labels for the other groups to maintain consistency and avoid visual conflicts.

[silverwind]

Sounds like a plan, I will try that.