test stability improvement. #1698

methane · 2025-04-20T11:13:30Z

ensuring performance schema is enabled when testing some performance schema results
Added logic to check if the default collation is overridden by the server character_set_collations
ensure using IANA timezone in test, since tzinfo depending on system won't have deprecated tz like "US/Central" and "US/Pacific"

Checklist

Code compiles correctly
Created tests which fail without the change (if possible)
All tests passing
Extended the README / documentation, if necessary
Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

Tests
- Improved collation test to handle server-specific collation overrides and updated failure messages.
- Updated tested time zones in timezone conversion tests for broader coverage and adjusted reference time zone.
- Enhanced connection attributes test to automatically skip if the server's performance schema is disabled.

* ensuring performance schema is enabled when testing some performance schema results * Added logic to check if the default collation is overridden by the server character_set_collations * ensure using IANA timezone in test, since tzinfo depending on system won't have deprecated tz like "US/Central" and "US/Pacific"

coderabbitai · 2025-04-20T11:13:37Z

Walkthrough

This update enhances several tests in driver_test.go. The TestCollation test now accounts for server-enforced collation overrides by parsing the @@character_set_collations variable and adjusting expectations accordingly. In TestTimezoneConversion, the set of time zones tested was revised, and the reference time zone changed from US/Central to America/New_York. The TestConnectionAttributes test now checks if the performance schema is enabled before running, skipping the test if it is not. No changes were made to exported or public function signatures.

Changes

File(s)	Change Summary
driver_test.go	Enhanced `TestCollation` to handle server collation overrides; updated `TestTimezoneConversion` time zones and reference time; added check for performance schema in `TestConnectionAttributes` to conditionally skip the test.

Sequence Diagram(s)

sequenceDiagram
    participant Test as TestConnectionAttributes
    participant Server as MySQL Server

    Test->>Server: Query performance_schema variable
    Server-->>Test: Return value (ON/OFF)
    alt performance_schema is ON
        Test->>Server: Query connection attributes
        Server-->>Test: Return attributes
    else performance_schema is OFF
        Test->>Test: Skip test
    end

Possibly related PRs

fix missing skip test when there is no DB available #1594: Both PRs modify driver_test.go to improve test robustness by conditionally skipping tests based on environment conditions, though they address different skip conditions.

Suggested reviewers

shogo82148

Poem

In the warren of code, we test and we tweak,
Collations and time zones, the bugs we now seek.
If schemas aren’t present, we quietly hop by,
Adjusting our watches as timezones fly.
With every test run, our confidence grows—
A rabbit’s delight as the green checkmark shows! 🐇✅

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 879eb11 and 98f445c.

📒 Files selected for processing (1)

driver_test.go (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (20)

GitHub Check: test (ubuntu-latest, 1.23, 9.0)
GitHub Check: test (macos-latest, 1.24, mariadb-11.2)
GitHub Check: test (ubuntu-latest, 1.22, 9.0)
GitHub Check: test (windows-latest, 1.24, mariadb-10.11)
GitHub Check: test (windows-latest, 1.24, mariadb-10.5)
GitHub Check: test (windows-latest, 1.24, mariadb-10.6)
GitHub Check: test (windows-latest, 1.24, mariadb-11.1)
GitHub Check: test (windows-latest, 1.24, mariadb-11.4)
GitHub Check: test (windows-latest, 1.24, 8.0)
GitHub Check: test (windows-latest, 1.24, 9.0)
GitHub Check: test (windows-latest, 1.24, 8.4)
GitHub Check: test (windows-latest, 1.24, mariadb-11.2)
GitHub Check: test (macos-latest, 1.24, mariadb-11.1)
GitHub Check: test (macos-latest, 1.24, 8.0)
GitHub Check: test (windows-latest, 1.24, 5.7)
GitHub Check: test (ubuntu-latest, 1.24, mariadb-11.1)
GitHub Check: test (ubuntu-latest, 1.24, 5.7)
GitHub Check: test (ubuntu-latest, 1.24, mariadb-11.4)
GitHub Check: test (ubuntu-latest, 1.24, 9.0)
GitHub Check: test (ubuntu-latest, 1.24, 8.4)

🔇 Additional comments (5)

driver_test.go (5)

1633-1658: Great enhancement to handle server-enforced collations!

This change improves test stability by accommodating servers that override the default collation via character_set_collations. The code now properly detects when the server forces a different collation for a charset and adjusts expectations accordingly.

1721-1721: Good switch to IANA standard timezones

Replacing US/Central and US/Pacific with IANA standard timezone names (America/New_York and Asia/Hong_Kong) improves test stability across different environments. IANA timezone identifiers are the preferred standard.

1729-1730: Correctly updated reference timezone for consistency

The reference time zone was properly updated from US/Central to America/New_York to match the list of tested timezones.

1749-1749: Updated error message to match the new timezone reference

Properly updated error message to reflect the new timezone reference (America/New_York).

3577-3585: Good defensive check for performance schema availability

This change improves test stability by checking if the performance schema is enabled before querying it. This prevents test failures on MySQL instances where performance_schema is disabled.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coveralls · 2025-04-20T11:18:45Z

coverage: 83.048%. remained the same
when pulling 98f445c on methane:fix-test
into 879eb11 on go-sql-driver:master.

methane merged commit f433f1f into go-sql-driver:master Apr 20, 2025
38 checks passed

methane deleted the fix-test branch April 20, 2025 11:24

coderabbitai bot mentioned this pull request Apr 21, 2025

simplify collation tests #1700

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test stability improvement. #1698

test stability improvement. #1698

Uh oh!

methane commented Apr 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 20, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coveralls commented Apr 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

test stability improvement. #1698

test stability improvement. #1698

Uh oh!

Conversation

methane commented Apr 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coveralls commented Apr 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

methane commented Apr 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)