Skip to content

Conversation

@mitar
Copy link
Contributor

@mitar mitar commented Oct 9, 2025

Fixes #519.

@mitar mitar requested a review from a team as a code owner October 9, 2025 12:19
@mitar mitar mentioned this pull request Oct 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 9, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updated mapstructure import paths from mitchellh/mapstructure to go-viper/mapstructure/v2 in two files. No code logic or public API changes.

Changes

Cohort / File(s) Summary
Mapstructure import path update
metadata/decode.go, protocol/attestation_safetynet.go
Switched imports to github.com/go-viper/mapstructure/v2 from github.com/mitchellh/mapstructure; no other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I nudge my nose at version two,
Hop hop—imports fresh and new.
No wires crossed, no structs askew,
Just tidy paths the carrots knew.
Bun-approved, we’re shipping through! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly states the primary change, specifying the dependency update to github.com/go-viper/mapstructure/v2 in a concise conventional commit style.
Linked Issues Check ✅ Passed The pull request updates all mapstructure imports to the v2 module path as requested in issue #519, fulfilling the version bump requirement for mapstructure 2.x.
Out of Scope Changes Check ✅ Passed All modifications are limited to changing mapstructure import paths, and no unrelated code or functionality has been introduced beyond the linked issue’s scope.
Description Check ✅ Passed The description directly references the linked issue being fixed and aligns with the dependency update, confirming its relevance to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

james-d-elliott
james-d-elliott previously approved these changes Nov 9, 2025
Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.95%. Comparing base (689cf3e) to head (84ed2a2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files          37       37           
  Lines        2449     2449           
=======================================
  Hits         1101     1101           
  Misses       1143     1143           
  Partials      205      205           
Files with missing lines Coverage Δ
metadata/decode.go 69.78% <ø> (ø)
protocol/attestation_safetynet.go 39.34% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james-d-elliott james-d-elliott enabled auto-merge (squash) November 9, 2025 02:59
@james-d-elliott james-d-elliott merged commit 9a8c2c4 into go-webauthn:master Nov 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump mapstructure version

2 participants