-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
outpost/proxyv2: handle PostgreSQL passwords with spaces and special chars + more tests #18211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…characters And modify / add some more tests and a bit of refactoring
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations canceled.
|
…te check Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dominic R <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18211 +/- ##
==========================================
- Coverage 92.95% 92.91% -0.05%
==========================================
Files 869 869
Lines 48116 48116
==========================================
- Hits 44728 44706 -22
- Misses 3388 3410 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ead227a27273f5b6a4cda7da89abc81741f0ba14
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ead227a27273f5b6a4cda7da89abc81741f0ba14Afterwards, run the upgrade commands from the latest release notes. |
| switch cfg.SSLMode { | ||
| case "require": | ||
| // Verify the server certificate (secure by default) | ||
| tlsConfig.InsecureSkipVerify = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change, as-is, is a breaking change that does not conform to the Postgres or Authentik documentation. If SSL mode is set to require, the documented behavior is to not check certificate validity:
-
https://docs.goauthentik.io/install-config/configuration/ (currently not viewable due to the ongoing CloudFlare outage)
This change instead makes "require" equivalent to "verify-ca". If this is intended to be the case, it should be documented as a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I need to change that, Good catch.
And modify / add some more tests and a bit of refactoring
Closes: #18175
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)