Skip to content

providers/scim: fix PATCH for AWS #18230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

providers/scim: fix PATCH for AWS #18230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcb7ac9
Fix SCIM for AWS
Nov 14, 2025
f944ddb
Batch AWS PATCH requests
Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion authentik/providers/scim/clients/groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
)
from authentik.providers.scim.clients.schema import Group as SCIMGroupSchema
from authentik.providers.scim.models import (
SCIMCompatibilityMode,
SCIMMapping,
SCIMProvider,
SCIMProviderGroup,
Expand Down Expand Up @@ -127,6 +128,34 @@ def update(self, group: Group, connection: SCIMProviderGroup):

def _update_patch(
self, group: Group, scim_group: SCIMGroupSchema, connection: SCIMProviderGroup
):
"""Apply provider-specific PATCH requests"""
match connection.provider.compatibility_mode:
case SCIMCompatibilityMode.AWS:
self._update_patch_aws(group, scim_group, connection)
case _:
self._update_patch_general(group, scim_group, connection)
return self.patch_compare_users(group)

def _update_patch_aws(
self, group: Group, scim_group: SCIMGroupSchema, connection: SCIMProviderGroup
):
"""Run PATCH requests for supported attributes"""
group_dict = scim_group.model_dump(mode="json", exclude_unset=True)
self._patch_chunked(
connection.scim_id,
*[
PatchOperation(
op=PatchOp.replace,
path=attr,
value=group_dict[attr],
)
for attr in ("displayName", "externalId")
],
)

def _update_patch_general(
self, group: Group, scim_group: SCIMGroupSchema, connection: SCIMProviderGroup
):
"""Update a group via PATCH request"""
# Patch group's attributes instead of replacing it and re-adding users if we can
Expand All @@ -147,7 +176,6 @@ def _update_patch(
exclude_none=True,
),
)
return self.patch_compare_users(group)

def _update_put(self, group: Group, scim_group: SCIMGroupSchema, connection: SCIMProviderGroup):
"""Update a group via PUT request"""
Expand Down