Add 32-bit architecture support for prebuilt bindings #2
+169
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate separate bindings for 32-bit and 64-bit targets to ensure correct layout tests on both architectures. This should fix compilation on wasm32 and other 32-bit platforms without runtime workarounds. Targets supported: - 64-bit: platform-specific (windows, macos, linux_64 as a catch-all) - 32-bit: shared linux_32 for all 32-bit targets (wasm32, i686)
- Add load_gdextension_header_rs_32() and load_gdextension_header_rs_64() which allow build scripts to select bindings based on CARGO_CFG_TARGET_POINTER_WIDTH - Deprecate load_gdextension_header_rs() which uses compile-time cfg
ufoot
added a commit
to ufoot/gdext
that referenced
this pull request
Dec 16, 2025
Prebuilt bindings previously used a runtime workaround that stripped layout tests when cross-compiling to 32-bit. This was fragile and didn't validate struct layouts on 32-bit targets. Changes: - Add TargetPointerWidth enum and generate_rust_binding_for_target() for generating bindings for a specific architecture via clang's --target flag - Export write_gdextension_headers_for_target() for godot4-prebuilt to generate both 32-bit and 64-bit bindings from a single host - Update prebuilt mode to select bindings using CARGO_CFG_TARGET_POINTER_WIDTH (the actual cross-compile target, not the host) - Remove strip_bindgen_layout_tests() workaround - no longer needed since prebuilt artifacts now include proper architecture-specific bindings. This should be squashed with previous commits, but until this is validated let's keep full history of what's there. Requirements: - this requires godot-rust/godot4-prebuilt#2 or similar, will not work with current tip-of-master.
Member
|
Hi, like I wrote in the downstream PR:
This repo is not meant for pull requests. Please have some patience until I find time to update the generator 🙂 May I ask if you have used AI tools in the generation of this or the gdext pull request? |
ufoot
added a commit
to ufoot/gdext
that referenced
this pull request
Dec 16, 2025
Prebuilt bindings previously used a runtime workaround that stripped layout tests when cross-compiling to 32-bit. This was fragile and didn't validate struct layouts on 32-bit targets. Changes: - Add TargetPointerWidth enum and generate_rust_binding_for_target() for generating bindings for a specific architecture via clang's --target flag - Export write_gdextension_headers_for_target() for godot4-prebuilt to generate both 32-bit and 64-bit bindings from a single host - Update prebuilt mode to select bindings using CARGO_CFG_TARGET_POINTER_WIDTH (the actual cross-compile target, not the host) - Remove strip_bindgen_layout_tests() workaround - no longer needed since prebuilt artifacts now include proper architecture-specific bindings. This should be squashed with previous commits, but until this is validated let's keep full history of what's there. Requirements: - this requires godot-rust/godot4-prebuilt#2 or similar, will not work with current tip-of-master.
Author
|
Ah OK, sorry, my bad, I probably did not RTFM enough about contributing guidelines etc. Will close this PR if that's not the way to go, no worries. |
Author
I do have some AI completion enabled on my editor so implicitly yes, I do use AI tools unless I explicitly disable my default dev workflow. More precisely I am using this copilot.el |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to elaborate on godot-rust/gdext#1444 and prepare ground for a proper fix.
Generate separate bindings for 32-bit and 64-bit targets to ensure correct layout tests on both architectures. This should fix compilation on wasm32 and other 32-bit platforms without runtime workarounds.
Targets supported:
Questions @Bromeon before I move further on this one, this PR renames stuff that was
_linux.rsto_linux_64.rsor_linux_32.rs. And generally speaking appends 32/64 to anything that was "just the default linux path" before. This is likely going to be a breaking change. My view on this is that it's safer to have explicit_64and_32when there could be a differnce. As opposed to_linux.rsis 64-bit implicitly and_linux_32.rsis here for the exceptional case we want 32-bit. But migration would be smoother if we were to just introduce_32.rsand keep the rest unchanged.TL;DR I am not sure about naming ;)