Skip to content

Test that internal classes work as expected #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jul 14, 2025

This is the companion PR to godotengine/godot#108614 that also adds to the automated tests to verify that internal classes work as expected

Marking as a DRAFT because I'm not entirely sure that godotengine/godot#108614 is a good idea. :-) I'll take this out of DRAFT if that one ends up being merged

@dsnopek dsnopek added this to the 4.x milestone Jul 14, 2025
@dsnopek dsnopek requested a review from a team as a code owner July 14, 2025 19:33
@dsnopek dsnopek added the bug This has been identified as a bug label Jul 14, 2025
@dsnopek dsnopek marked this pull request as draft July 14, 2025 19:33
@dsnopek dsnopek changed the title [DRAFT] Test that internal classes work as expected Test that internal classes work as expected Jul 23, 2025
@dsnopek dsnopek force-pushed the test-internal-classes branch from 239c7cd to 309b17b Compare July 23, 2025 20:07
@dsnopek dsnopek marked this pull request as ready for review July 23, 2025 20:07
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.
It would be nice if we had some way to warn people of this change when they update (ideally through the compiler). But I can't think of one. I guess they'll find out when they suddenly can't instantiate their classes anymore on test.

@dsnopek
Copy link
Collaborator Author

dsnopek commented Jul 23, 2025

I guess they'll find out when they suddenly can't instantiate their classes anymore on test.

We can add a note about it on the "Upgrading from Godot 4.4 to Godot 4.5" page (like the 4.3 to 4.4 one), but, yeah, folks will probably see things break first

@dsnopek dsnopek merged commit 4f80491 into godotengine:master Jul 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants