Rename interface to gdn_interface because it's a defined keyword #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Oct 28, 2021
BastiaanOlij
force-pushed
the
rename_interface
branch
from
4bfddc5 to
ef528d3
Compare
Collaborator
Author
|
wrapped.hpp changed a lot due to clang-format not having been ran on it, or so it seems... |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For plugins authored for Windows, especially those that need to call into system APIs, we need to include
windows.hwhich is always fun and games as Microsoft has a habit of redefining stuff to their needs.One of those redefines is
#define interface __STRUCT__which is causing havoc to our code base.We can't undefine this, the redefine is part of Microsofts COM system which is a prime candidate to have plugins build against.
We use
interfaceas the variable name to store our interface pointer into Godot. This PR simply renames it togdn_interface.I've also added an include of
windows.hinto our test project so we capture similar issues early through CI.