-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added an OpenXR render models demo #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added an OpenXR render models demo #1218
Conversation
954d379
to
368fe36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The code looks good. I did a quick "smoke test" on the Meta Quest, and the project didn't explode, but it doesn't support the render models extensions yet so I can't do a real test. I haven't had a chance yet to try on an OpenXR runtime that does support it.
Only a handful of nitpicks on the README text
368fe36
to
dad7890
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I did a quick test with SteamVR, and everything seems to be work fine as well :-)
root = true | ||
|
||
[*] | ||
charset = utf-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root of the repo already has a .editorconfig
, why do we need one in this project?
Same for the Git metadata. In most repos these are useful metadata files to have in the project, but specifically in this repository, we have many projects, so we don't need these per-project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably because Godot creates that file when you open the project and I never even noticed it was there.
Happy to remove it, but I think we should add an entry in our root .gitignore
file if we want to prevent these files from being included. I am likely far from the first, nor will I be the last, who doesn't realise Godot has created this file and we'd rather not have it checked in.
This is a very simple demo in support of godotengine/godot-docs#11014
It shows how to use the new render models API including adding a simplified collision hands implementation.
I've left everything else out, no movement code or interaction code, as it would just distract away from the main purpose.
Todos: