-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add a camera feed demo in misc #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
32d07e5
to
d7aa707
Compare
d7aa707
to
31daada
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the demo requires 4.5 (even on unsupported platforms), as it references the monitoring_feeds
property which doesn't exist on 4.4.1. This is not essential to fix to merge (it's fine for this demo to be 4.5+), but I thought I'd mention nonetheless.
Some feedback:
- The demo should be switched to the Compatibility rendering method if it doesn't use features exclusive to Forward+/Mobile.
- The demo's folder should be renamed from
camerafeed
tocamera_feed
. application/run/low_processor_mode
should be enabled in the Project Settings to reduce CPU/GPU utilization when idle.
95f148b
to
7c11b39
Compare
@Calinou
|
The demo should use a lower window size on desktop platforms. Otherwise, on a 1080p display, it'll look like this when run from the editor with game window embedding enabled: You can do this by changing Window Width Override and Window Height Override to |
7c11b39
to
c48aa42
Compare
|
bea0171
to
aea91ff
Compare
aea91ff
to
292547b
Compare
This is a demo project for camera feed and camera server.
Supported Platforms
Limitations
Pull requests have been proposed for Windows, iOS and Web.
Add CameraFeed support for Windows godot#105476macOS and iOS are incomplete due to bugs.
Support CameraServer.feeds_updated signal.
CameraServer
feeds_updated
signal, and document async behavior godot#108165Preview