-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Improve the pygments lexer to cover GDScript 2 better #11217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Hugo Locurcio <[email protected]>
@@ -440,50 +1406,172 @@ def innerstring_rules(ttype): | |||
Name.Decorator, | |||
), | |||
], | |||
"numbers": [ | |||
"operator": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is singular as opposed to other cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. somewhat arbitrary. name
, stringescape
, comment
and a few others are singular too. for the most part plural would make sense, except whitespace
seems awkward. perhaps singular everywhere makes the most sense?
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
we've recently updated the gdscript lexer for our own documentation, this is a port of those changes to fit the godot docs
please check as many pages as you can for errors i might have missed.
also let me know if the colors are fine like this. i think some of the existing colors may be from an older theme and not quite up to date, but i didn't touch them for now.
main changes are functions having proper blue color now, global functions being purple, all classes getting the correct greens (including builtins and types having the different green), and proper colors for $String, string names and node paths