Skip to content

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 16, 2025

  • Mention support for comments in .gdextension files.
  • List recommended import options for GDExtension icons.

@Calinou Calinou force-pushed the gdextension-file-libraries-relative-path branch 4 times, most recently from 5ccec64 to 78747d7 Compare October 16, 2025 20:29
@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:gdextension cherrypick:4.4 cherrypick:4.5 labels Oct 16, 2025
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to switch the example to use relative names.
We discussed this in GDExtension meetings before, and concluded (iirc) that relative paths are preferable since this supports moving around and renaming the gdextension without having to worry about the .gdextension file. This is also the reason we changed it in the template.
I don't think there are any advantages to using absolute paths, so I'm not sure I'd even mention them.

@Calinou
Copy link
Member Author

Calinou commented Oct 16, 2025

I would prefer to switch the example to use relative names.

Done.

- Mention support for comments in `.gdextension` files.
- List recommended import options for GDExtension icons.
@Calinou Calinou force-pushed the gdextension-file-libraries-relative-path branch from 72fcb7b to c0ebfbc Compare October 16, 2025 22:25
@Ivorforce Ivorforce requested a review from a team October 16, 2025 22:32
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

Comment on lines +56 to +57
macos.debug = "bin/libgdexample.macos.template_debug.framework" ; Inline comments are also allowed.
macos.release = "bin/libgdexample.macos.template_release.framework"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the template, we did all the paths starting with ./, which, if I remember correctly was to fix a MacOS issue? And we also use .dylib in the template and not .framework, which I also remember discussing being to workaround some issue.

Do you folks remember the details?

Anyway, if there was a reason for those changes, we should do them in the docs as well

Copy link
Member

@Ivorforce Ivorforce Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Yea, I believe the macOS load issue is still around, so changing to ./ format would be good.

And yea, the change from framework to dylib also definitely makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.4 cherrypick:4.5 enhancement topic:gdextension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants