Skip to content

Make Vector<T>::bsearch use a const receiver #103047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make Vector<T>::bsearch use a const receiver #103047

wants to merge 1 commit into from

Conversation

BenLubar
Copy link

@BenLubar BenLubar commented Feb 19, 2025 •
edited
Loading

Allows binary searches on const Vector<T> values.

This matches const Array.

See also godotengine/godot-cpp#1711.

@BenLubar BenLubar requested a review from a team as a code owner February 19, 2025 19:53
@BenLubar BenLubar mentioned this pull request Feb 19, 2025
Open
@BenLubar BenLubar changed the title make Vector<T>::bsearch use a const receiver Make Vector<T>::bsearch use a const receiver Feb 19, 2025
@BenLubar BenLubar force-pushed the vector-bsearch-const branch from 6a14d2d to 4d83361 Compare February 19, 2025 20:04
@BenLubar BenLubar requested a review from a team as a code owner February 19, 2025 20:04
@clayjohn clayjohn added this to the 4.x milestone Feb 20, 2025
@AThousandShips
Copy link
Member

This is already implemented in:

@BenLubar
Copy link
Author

Closed as duplicate of #90341

@BenLubar BenLubar closed this Feb 22, 2025
@akien-mga akien-mga removed this from the 4.x milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived breaks compat enhancement topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenLubar @AThousandShips @akien-mga @clayjohn