Support overriding speaker_mode in AudioServer
#105934
Conversation
BuzzLord
force-pushed
the
audio-server-override-channels
branch
from
f93e0fa to
de3521e
Compare
|
Updated based on the feedback from the most recent audio team meeting. I left the new commit as is for now (i.e. didn't I also made a little project to help show off the functionality. test-godot-channel-override.zip
|
|
I think the PR should be split in two:
|
It has been with the most recent update. Overriding is not in project settings, its done with get/set methods on AudioServer. |
Ohhh, I see. The settings I saw in the project were lingering options then. Sorry. |
BuzzLord
force-pushed
the
audio-server-override-channels
branch
from
de3521e to
e195f67
Compare
BuzzLord
changed the title
|
Refactored this to only handle setting/overriding the Channel remapping will be moved to another PR. |
adamscott
changed the title
speaker_mode in AudioServer
The AudioServer processes audio samples as a number of stereo channels, which are copied to the audio driver buffers. This commit adds the ability to remap AudioServer channels to different driver channels, primarily for debugging purposes. The way it is configured is with get/set methods on AudioServer, exposed in GDScript/C#. This depends on the speaker_mode override PR godotengine#105934. It only allows for remapping the stereo channels Godot works with, and not for mixing left/right samples between channels.
adamscott
left a comment
adamscott
left a comment
There was a problem hiding this comment.
Discussed during the 2025-06-24 audio meeting. Seems ok so far. Would be great to add it to 4.5. This is a feature after the feature freeze, but it's quite a small change for the functionality it brings to the table.
Will test it and comment afterwards later today.
| ProjectSettings::get_singleton()->connect("settings_changed", callable_mp(this, &AudioServer::project_settings_changed)); | ||
| } | ||
|
|
||
| void AudioServer::project_settings_changed() { | ||
| lock(); | ||
| speaker_mode_config = GLOBAL_GET("audio/general/speaker_mode"); | ||
| unlock(); | ||
| } |
There was a problem hiding this comment.
I'm wondering if there's another setting that works like this in the project. This is primarily for the editor side, so should we wrap this behind a is_editor_hint()?
BuzzLord
force-pushed
the
audio-server-override-channels
branch
2 times, most recently
from
78ed01e to
e9058c7
Compare
Add support (via project settings) to AudioServer to change the speaker_mode that Godot uses internally, independent of the audio driver used. Can accept a 'Default' value, using the audio driver speaker_mode, or use the specified mode. This is intended to be used to help troubleshoot audio issues when testing with different speaker setups, but can be used to force a specific speaker_mode on projects where appropriate. Co-authored-by: A Thousand Ships <[email protected]>
BuzzLord
force-pushed
the
audio-server-override-channels
branch
from
e9058c7 to
70688bf
Compare
|
After today's discussion, it seems that we're leaning towards the idea that this PR probably only applies to developers troubleshooting engine issues, and not as a useful feature to be exposed in games. It was suggested that this could be done from the OS level, so I did some poking around to try it. I was able to use the VB-Audio VB-CABLE driver to effectively do what this PR does. It should work for Windows and Mac. Linux almost certainly also has an equivalent feature. For Windows:
This results in the engine using 7.1 surround, and I confirmed the Would it make more sense to just write some documentation describing how to configure these external methods rather than include this PR in the engine itself? |
3 participants
Updated: Refactored this to only handle setting/overriding the
speaker_modeof a project. Channel remapping will be moved to another PR.Adds support (via project settings under
audio/general/speaker_mode) to theAudioServerto change the speaker mode (i.e. number of channels) that Godot uses internally, independent of the audio driver used. It can be used to test more channels (e.g. 7.1 surround when using a stereo audio setup), or fewer channels (e.g. stereo when using a 7.1 surround setup). This is intended to be used to help troubleshoot audio issues when testing with different speaker setups, or hard coding a speaker mode for a project.This PR also adds the ability to remap internal channels onto different output channels of the audio device. For example, you can remap the rear or side stereo channels of a 7.1 surround system into the front channels of a stereo system in order to verify the audio is correct.This is a extension of, and replacement for #105682. Like that PR, this feature makes it possible for Godot developers without the necessary surround sound peripheral to reproduce bugs and review fixes to issues that are the result of an unanticipated number of channels, such as: #92532