Fix selecting wrong vertices in the Polygon2D editor when adding a polygon #108249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This loop could be extracted to a method, it's the same in both cases. |
Nikitf777
force-pushed
the
polygon-2d-editor-fix-selecting-wrong-point
branch
from
e93a58f to
abfa249
Compare
| Vector2 tuv = mtx.xform(editing_points[i]); | ||
| real_t dist = tuv.distance_to(mb->get_position()); | ||
| if (dist < 8 && dist < closest_dist) { | ||
| if (tuv.distance_to(mb->get_position()) < 8) { |
Member
There was a problem hiding this comment.
Suggested change
| if (tuv.distance_to(mb->get_position()) < 8) { | |
| if (tuv.distance_squared_to(mb->get_position()) < 64.0) { |
Better to avoid the square root if we don't need the result here
Contributor
Author
There was a problem hiding this comment.
This is not the only place where it makes sense. I can change it everywhere here or create another pull request with these optimizations.
Member
There was a problem hiding this comment.
Been looking into that myself so might make a PR soon, just to avoid double work
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied the same fix as in #107932, but for another action:
ACTION_ADD_POLYGON. Sorry, I didn't know that this algorithm was used twice in the code. But this one seems to be the last. The interesting thing is that this code seems to be writter by none other than @reduz. I wounder why did he implement it like this.