-
-
Notifications
You must be signed in to change notification settings - Fork 23.7k
Class docs: Fix ReflectionProbe note regarding Compatibility renderer support #108271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Calinou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
I'm sorry for being a bit late. Thank you all for the reviews and suggestions! |
|
Could you squash the commits? See our PR workflow documentation for details: https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase |
|
I'm sorry for being late (again), but the fixup is finally done! Let me know if anything else is missing. |
Repiteo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, and everything looks good!
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Class docs: Fix ReflectionProbe note regarding Compatibility renderer support
Right now, the class description states:
This has been fixed in Godot 4.3 ( #88056 ) and the documentation page has been updated, but the class page remains unfixed. This PR aims to fix this by changing the third paragraph in the class page:
to this: